refactor: Import Node type from planx-core
#3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/editor-node-type
branch
from
c38bec5 to
d94c320
Compare
DafyddLlyr
commented
Sep 12, 2024
There was a problem hiding this comment.
This is the main file updated in this PR.
DafyddLlyr
commented
Sep 12, 2024
Comment on lines
+39
to
+43
| export interface Response { | ||
| question: Node & { id: NodeId }; | ||
| selections: Array<Node & { id: NodeId }>; | ||
| hidden: boolean; | ||
| } |
There was a problem hiding this comment.
This is pulled out here to reuse existing types, rather than redefine them (as seen in editor.planx.uk/src/types.ts)
jessicamcinchak
approved these changes
Sep 12, 2024
| /** | ||
| * Looser Node type with `any` data | ||
| * @deprecated Should share type with PlanX core once `Value` is retired and Flow Graph is typed | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Nodewithplanx-coreStorenamespace