feat: Add internal portal wrapper to search cards #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/interal-portal-ui-wrapper
branch
from
520a5c9 to
f3cae5b
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
Sep 13, 2024
jessicamcinchak
approved these changes
Sep 13, 2024
| @@ -6,6 +6,7 @@ import CloudUpload from "@mui/icons-material/CloudUpload"; | |||
| import ContactPage from "@mui/icons-material/ContactPage"; | |||
| import CopyAll from "@mui/icons-material/CopyAll"; | |||
| import Create from "@mui/icons-material/Create"; | |||
| import DoorFrontOutlined from "@mui/icons-material/DoorFrontOutlined"; | |||
There was a problem hiding this comment.
nit: could a simple folder icon be a more straightforward option here to communicate "this is nested inside something else"? Took me a while to make out exactly what the door was as the size it's used.
Maybe also more in line with future "what do we call things" conversations where internal portals become "folders" and external portals become "subscribed flows" or similar!
There was a problem hiding this comment.
Yep this is a fair question!
I'm just re-using and formalising the existing icon here, as seen in the flow graph.
I'll keep as-is for now, but let's re-evaluate this in line with our "naming things" chat 👍
editor.planx.uk/src/pages/FlowEditor/components/Sidebar/Search/SearchResultCard/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?