Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): Editor modal #3676

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat(page): Editor modal #3676

merged 2 commits into from
Sep 16, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 16, 2024

What does this PR do?

  • Sets up Editor modal for Page component
  • Copies "Advert Consent" schema from List component - this is being used as a page there
image

@DafyddLlyr DafyddLlyr changed the base branch from main to dp/page-boilerplate September 16, 2024 07:57
Comment on lines +7 to +10
export interface PageSchema extends Schema {
min: 1;
max: 1;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enforces that Pages can only have one item, whilst allowing us to re-use all logic from useSchema()

@DafyddLlyr DafyddLlyr requested a review from a team September 16, 2024 08:00
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good here, happy for this to merge once Vultr sorted

Copy link

github-actions bot commented Sep 16, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit a66f4ea into dp/page-boilerplate Sep 16, 2024
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/page-editor branch September 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants