Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(page): Public interface #3677

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(page): Public interface #3677

merged 1 commit into from
Sep 16, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 16, 2024 •
edited
Loading

What does this PR do?

Creates public interface for the Page component - a very simple implementation for the existing SchemaFields 👌

image

@DafyddLlyr DafyddLlyr requested a review from a team September 16, 2024 08:02
@DafyddLlyr DafyddLlyr force-pushed the dp/page-public-interface branch from e315223 to 43e9455 Compare September 16, 2024 08:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

ianjon3s
ianjon3s approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, a natural extension (simplification) of the List Component

@DafyddLlyr DafyddLlyr merged commit a973472 into dp/page-editor Sep 16, 2024
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/page-public-interface branch September 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s