feat(page): Handle submit and "back" functionality #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/page-public-interface
branch
from
e315223 to
43e9455
Compare
DafyddLlyr
force-pushed
the
dp/page-handle-submit
branch
from
8049191 to
0e6b5df
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Sep 16, 2024
| previousValues: getPreviouslySubmittedData(props), | ||
| }); | ||
|
|
||
| const onSubmit: FormikConfig<SchemaUserData>["onSubmit"] = (data) => { |
There was a problem hiding this comment.
As with the List component, we're preversing both forms of data here as opposed to writing to and parsing from a single format.
This seems like an ok approach, especially as it's following an established pattern?
There was a problem hiding this comment.
By "preversing both forms of data" you're referring to defaultPassportData and flattenedData?
There was a problem hiding this comment.
Yes, that's right. We could parse/map/serialise both into a single structure and then unpack that on "back" navigation, but I'm proposing we allow both just now 👍
DafyddLlyr
force-pushed
the
dp/page-handle-submit
branch
from
a119474 to
ed12378
Compare
jessicamcinchak
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
maincommit across projects