Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(page): Drop "PAGE" feature flag #3682

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore(page): Drop "PAGE" feature flag #3682

merged 1 commit into from
Sep 18, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 16, 2024 •
edited
Loading

What does this PR do?

  • Removes PAGE feature flag
  • Serves as a testing playground for the Page component

I'll rebase and advertise this PR (with testing notes) once the follow PRs have progressed -

@DafyddLlyr DafyddLlyr changed the title chore(page): Drop feature flag chore(page): Drop "PAGE" feature flag Sep 16, 2024
@DafyddLlyr DafyddLlyr marked this pull request as draft September 16, 2024 14:29
@DafyddLlyr DafyddLlyr added the demo Demo environment being used by an external team label Sep 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/drop-page-feature-flag branch from 7a8ce00 to d8b8e05 Compare September 17, 2024 09:44
@DafyddLlyr DafyddLlyr marked this pull request as ready for review September 18, 2024 10:14
@DafyddLlyr DafyddLlyr marked this pull request as draft September 18, 2024 10:14
@DafyddLlyr DafyddLlyr force-pushed the dp/drop-page-feature-flag branch from d8b8e05 to 6865772 Compare September 18, 2024 10:15
@DafyddLlyr DafyddLlyr requested a review from a team September 18, 2024 10:15
@DafyddLlyr DafyddLlyr marked this pull request as ready for review September 18, 2024 10:15
@DafyddLlyr DafyddLlyr removed the demo Demo environment being used by an external team label Sep 18, 2024
RODO94
RODO94 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DafyddLlyr DafyddLlyr merged commit 0c2dd87 into main Sep 18, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-page-feature-flag branch September 18, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RODO94 RODO94 RODO94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @RODO94