test[e2e]: refactor, and add to public-facing editor flow test #3683
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
| cd api.planx.uk | ||
| pnpm dlx lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,26 @@ | ||
| import { Browser, expect, test } from "@playwright/test"; | ||
| import type { Context } from "../helpers/context"; | ||
| import { | ||
| contextDefaults, | ||
| setUpTestContext, | ||
| tearDownTestContext, | ||
| } from "../helpers/context"; | ||
| import { getTeamPage } from "../helpers/getPage"; | ||
| import { createAuthenticatedSession } from "../helpers/globalHelpers"; | ||
| import { | ||
| answerAddressInput, | ||
| answerChecklist, | ||
| answerContactInput, | ||
| answerDateInput, | ||
| answerFindProperty, | ||
| answerNumberInput, | ||
| answerQuestion, | ||
| answerTextInput, | ||
| clickContinue, | ||
| } from "../helpers/userActions"; | ||
| import { PlaywrightEditor } from "../pages/Editor"; | ||
|
|
||
| test.describe("Flow creation, publish and preview", () => { | ||
| let context: Context = { | ||
| ...contextDefaults, | ||
| }; | ||
|
|
@@ -52,166 +43,55 @@ test.describe("Navigation", () => { | |
| await tearDownTestContext(context); | ||
| }); | ||
|
|
||
| test("Create a flow", async ({ browser }) => { | ||
| const page = await getTeamPage({ | ||
| browser, | ||
| userId: context.user!.id!, | ||
| teamName: context.team.name, | ||
| }); | ||
|
|
||
| const editor = new PlaywrightEditor(page); | ||
|
There was a problem hiding this comment. Cool to see page object models in action here - seems like very worthwhile refactor / much easier to maintain and extend now ! |
||
|
|
||
| page.on("dialog", (dialog) => dialog.accept(serviceProps.name)); | ||
| await editor.addNewService(); | ||
|
|
||
| // update context to allow flow to be torn down | ||
| context.flow = { ...serviceProps }; | ||
|
|
||
| await editor.createQuestion(); | ||
| await editor.createNoticeOnEachBranch(); | ||
| await editor.createChecklist(); | ||
| await editor.createTextInput(); | ||
| await editor.createNumberInput(); | ||
| await editor.createDateInput(); | ||
| await editor.createAddressInput(); | ||
| await editor.createContactInput(); | ||
| await editor.createTaskList(); | ||
| await editor.createFindProperty(); | ||
| await editor.createDrawBoundary(); | ||
| await editor.createPlanningConstraints(); | ||
|
There was a problem hiding this comment. Per bigger picture approach questions in your PR description:
|
||
| await editor.createFileUpload(); | ||
| await editor.createNextSteps(); | ||
| await editor.createReview(); | ||
|
|
||
| await expect(editor.nodeList).toContainText([ | ||
| "Is this a test?", | ||
| "Yes! this is a test", | ||
| "Sorry, this is a test", | ||
| "Checklist item 1", | ||
| "Tell us about your trees.", | ||
| "How old are you?", | ||
| "When is your birthday?", | ||
| "What is your address?", | ||
| "What is your contact info?", | ||
| "What you should do next", | ||
| "Find property", | ||
| "Confirm your location plan", | ||
| "Planning constraints", | ||
| "File upload", | ||
| "Next steps", | ||
| "Check your answers before sending your application", | ||
| ]); | ||
| }); | ||
|
|
||
| test("Cannot preview an unpublished flow", async ({ | ||
|
|
@@ -321,5 +201,66 @@ test.describe("Navigation", () => { | |
| await expect( | ||
| page.locator("h1", { hasText: "Sorry, this is a test" }), | ||
| ).toBeVisible(); | ||
| await clickContinue({ page }); | ||
|
There was a problem hiding this comment. Adding to the 'user-facing' part of the test |
||
|
|
||
| await answerChecklist({ | ||
| page, | ||
| title: "A checklist title", | ||
| answers: ["Checklist item 1", "Second checklist item"], | ||
| }); | ||
| await clickContinue({ page }); | ||
|
|
||
| await answerTextInput(page, { | ||
| expectedQuestion: "Tell us about your trees.", | ||
| answer: "My trees are lovely", | ||
| continueToNext: true, | ||
| }); | ||
|
|
||
| await answerNumberInput(page, { | ||
| expectedQuestion: "How old are you?", | ||
| answer: 30, | ||
| continueToNext: true, | ||
| }); | ||
|
|
||
| await answerDateInput(page, { | ||
| expectedQuestion: "When is your birthday?", | ||
| day: 30, | ||
| month: 12, | ||
| year: 1980, | ||
| continueToNext: true, | ||
| }); | ||
|
|
||
| await answerAddressInput(page, { | ||
| expectedQuestion: "What is your address?", | ||
| addressLineOne: "1 Silver Street", | ||
| town: "Bamburgh", | ||
| postcode: "BG1 2SS", | ||
| continueToNext: true, | ||
| }); | ||
|
|
||
| await expect( | ||
| page.locator("h1", { hasText: "What is your contact info?" }), | ||
| ).toBeVisible(); | ||
| await answerContactInput(page, { | ||
| firstName: "Freddie", | ||
| lastName: "Mercury", | ||
| phoneNumber: "01234 555555", | ||
| email: "[email protected]", | ||
| }); | ||
| await clickContinue({ page }); | ||
|
|
||
| await expect( | ||
| page.locator("h1", { hasText: "What you should do next" }), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.locator("h2", { hasText: "Have a cup of tea" }), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.locator("h2", { hasText: "Continue through this flow" }), | ||
| ).toBeVisible(); | ||
| await clickContinue({ page }); | ||
|
|
||
| await answerFindProperty(page); | ||
| await clickContinue({ page }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split out into a 'page-refresh' test file to reduce the length of this one