Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Map and Label Copy Tests #3695

Merged
merged 6 commits into from
Sep 18, 2024
Merged

feat: Map and Label Copy Tests #3695

merged 6 commits into from
Sep 18, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Sep 17, 2024

What does this PR do?

This continues work on the tests for the Map and Label component, building up tests for the Copy from feature

Copy link

github-actions bot commented Sep 17, 2024

Removed vultr server and associated DNS entries

@RODO94 RODO94 marked this pull request as ready for review September 17, 2024 13:37
@RODO94 RODO94 requested a review from a team September 17, 2024 13:44
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, but all good!

const urgencyDiv = getByTitle("Urgency");
const urgencySelect = within(urgencyDiv).getByRole("combobox");

expect(getByLabelText("Species")).toHaveDisplayValue(mockTreeData.species);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DafyddLlyr is this the sort of thing you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@RODO94 RODO94 merged commit b248ecc into main Sep 18, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/mal-test-copy branch September 18, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants