feat: Map and Label Remove Tests #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
changed the title
|
Removed vultr server and associated DNS entries |
RODO94
force-pushed
the
rory/mal-test-remove
branch
from
e1b87e5 to
2670463
Compare
DafyddLlyr
requested changes
Sep 17, 2024
editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.test.tsx
Outdated
Show resolved
Hide resolved
DafyddLlyr
requested changes
Sep 17, 2024
editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.test.tsx
Outdated
Show resolved
Hide resolved
RODO94
commented
Sep 17, 2024
| addFeaturesToMap(map, [point1]); | ||
|
|
||
| const firstTabPanel = getByTestId("vertical-tabpanel-0"); | ||
|
|
||
| expect(firstTabPanel).toBeVisible(); | ||
|
|
||
| map = getByTestId("map-and-label-map"); | ||
| expect(map).toHaveAttribute("drawgeojsondata", mockFeaturePointObj); |
There was a problem hiding this comment.
@DafyddLlyr happy path drawgeojsondata check added here
DafyddLlyr
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following previous work on Map and Label testing, I am continuing through and testing the Remove feature.
To test the feature being deleted the map, I am accessing the
drawgeojsonattribute of<my-map>seemed a good way to confirm it has been deleted from the map itself. Open to alternative suggestions though.