Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Basic coverage for PlanningConstraints public interface #3700

Merged
merged 4 commits into from
Sep 18, 2024
Merged

test: Basic coverage for PlanningConstraints public interface #3700

merged 4 commits into from
Sep 18, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 18, 2024 •
edited
Loading

What?

Sets up very basic coverage of the public interface of the PlanningConstraints component.

Why?

@DafyddLlyr DafyddLlyr mentioned this pull request Sep 18, 2024
Merged
@DafyddLlyr DafyddLlyr requested a review from a team September 18, 2024 08:15
jessicamcinchak
jessicamcinchak approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long overdue, thanks for getting foundational mocks setup here 👍

One comment below re fetch logic, but otherwise looks good to go

editor.planx.uk/src/@planx/components/PlanningConstraints/Public.test.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit b15c023 into main Sep 18, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/planning-constraints-tests branch September 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak