fix: hide "Add a new editor" button from non-admin users #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jamdelion
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Clear and concise! ⭐
Thanks for sorting this, it was my bad for not covering this in the original ticket! I think I got a bit confused about the roles available/who was supposed to see what... 🙈 It's defo good advice to toggle off platform admin when testing pizzas, thanks 🍕
DafyddLlyr
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the second planning meeting in a row where Ian G has asked about / been a bit confused by adding and editing users and I think it's because he can see the add button as a
teamEditor, but doesn't have permission to actually use it.This change hides the "Add a new editor" from non-
platformAdminssimilar to the "Edit" button. Database-level permissions already look correct (eg onlyplatformAdminrole has "insert" permission onteam_memberstable).We've thrown this previous error: https://opensystemslab.slack.com/archives/C01E3AC0C03/p1725542317058179
Good reminder to ourselves to trigger our own
platformAdminstatus "off" sometimes when testing/code reviewing pizzas!