Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Save" button to MapAndLabel tabs #3720

Closed
wants to merge 1 commit into from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Sep 22, 2024

Adds an explicit "Save" button to each tab per user research feedback.

Intention is that "Save" will run schema validation for the active tab only and display field errors.

Screenshot from 2024-09-22 21-59-57

Open questions:

  • "List" uses "Save"/"Cancel" for active items, and "Edit"/"Remove" for inactive items - but we only have a single state of each tab here, is it okay to present "Save" & "Remove" without "Cancel" ?
  • Similarly, is "Save" actually too misleading here - eg do you expect your progress to be saved before "Continuing" if you were to "Save & resume" midway through filling out trees tabs because you "Saved" individual tabs?

Copy link

github-actions bot commented Sep 22, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member Author

Closing this as currently not moving forward. Linked from Trello ticket if we decide to revisit !

@jessicamcinchak jessicamcinchak deleted the jess/map-n-label-save-tab branch October 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant