Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create model file for Question #3726

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 23, 2024

What?

  • Moves Question to its own model.ts file

Why?

#3716 has slightly descended into a large messy type fixing PR which I was trying to avoid. I'm splitting it up into smaller, more atomic, PRs in order to better highlight and track the actual important changes.

@DafyddLlyr DafyddLlyr requested a review from a team September 23, 2024 10:13
Copy link

github-actions bot commented Sep 23, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DafyddLlyr DafyddLlyr merged commit 3be79b1 into main Sep 24, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/question-props-model branch September 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants