Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove additional Editor scroll #3734

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 27, 2024

Small CSS fix I've been meaning to take a look at for a while.

When the "test environment" banner is visible, it takes the FlowEditor over 100vh which we don't want. This PR fixes that 👍

Before

Screen.Recording.2024-09-27.at.13.33.31.mov

After

Screen.Recording.2024-09-27.at.13.42.36.mov

@DafyddLlyr DafyddLlyr marked this pull request as draft September 27, 2024 12:37
@DafyddLlyr DafyddLlyr force-pushed the dp/editor-sidebar-scroll branch from aa819c3 to 3e2ae25 Compare September 27, 2024 12:39
Copy link

github-actions bot commented Sep 27, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team September 27, 2024 12:56
@DafyddLlyr DafyddLlyr marked this pull request as ready for review September 27, 2024 12:56
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hitting some linting issues here - the pre-commit hook was failing to run.

Next PR I'll look at this a bit deeper and see if I can find vitest specific replacements here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #3735

@DafyddLlyr DafyddLlyr merged commit e7b3c94 into main Sep 30, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/editor-sidebar-scroll branch September 30, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants