feat(search): Enable data-only checkbox #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/search-basic-field
branch
from
7610459 to
a154cf7
Compare
DafyddLlyr
force-pushed
the
dp/search-basic-field
branch
from
a154cf7 to
b22d06d
Compare
| const toggleDataOnly = () => | ||
| isDataOnly() | ||
| ? formik.setFieldValue("facets", ALL_FACETS) | ||
| : formik.setFieldValue("facets", DATA_FACETS); |
There was a problem hiding this comment.
The logic here feels backwards to me based on naming?
There was a problem hiding this comment.
Thanks, updated naming 👍
| "data.schema.fields.data.description", | ||
| "data.schema.fields.data.options.description", | ||
| "data.schema.fields.data.options.text", | ||
| "data.schema.fields.data.options.data.val", |
There was a problem hiding this comment.
nit: I think data.schema.fields.data.options.data.val should be considered a data field only search term, rather than general search?
There was a problem hiding this comment.
Fantastic catch thank you! 🦅 👀 Looks like a copy/paste error
jessicamcinchak
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DATA_FACETSorALL_FACETSALL_FACETSScreen.Recording.2024-10-03.at.10.54.58.mov
Next steps...