feat: Handle editor sidebar visibility toggle on sidebar #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
| @@ -23,19 +26,24 @@ import StyledTab from "./StyledTab"; | |||
|
|
|||
| type SidebarTabs = "PreviewBrowser" | "History" | "Search" | "Console"; | |||
|
|
|||
| const Root = styled(Box)(({ theme }) => ({ | |||
| const SIDEBAR_WIDTH = 500; | |||
| const SIDEBAR_WIDTH_MINIMISED = 20; | |||
There was a problem hiding this comment.
nit: should these simply be set directly as strings to avoid the extra templating below?
There was a problem hiding this comment.
Great spot, updated 👍
jessicamcinchak
approved these changes
Oct 2, 2024
| @@ -23,19 +26,24 @@ import StyledTab from "./StyledTab"; | |||
|
|
|||
| type SidebarTabs = "PreviewBrowser" | "History" | "Search" | "Console"; | |||
|
|
|||
| const Root = styled(Box)(({ theme }) => ({ | |||
| const SIDEBAR_WIDTH = 500; | |||
| const SIDEBAR_WIDTH_MINIMISED = 20; | |||
There was a problem hiding this comment.
nit: should these be set directly as strings to avoid the extra templating step below?
| <Header> | ||
| <Box width="100%" display="flex"> | ||
| <input type="text" disabled value={urls.preview} /> | ||
| <Root isMinimised={isSidebarMinimised}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves toggle for show/hiding the editor sidebar to be placed on the sidebar itself.
Also stores the toggle position in localStorage so that the position is maintained when opening graph nodes or switching screens.
Example:
https://3747.planx.pizza/barking-and-dagenham/retrofit-guide