fix: Correctly construct URL by re-ordering portals #3773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
What's the solution?
getPathForNode()
is in opposite order (current node → parent → grandparent).reverse()
on the list of internal portals 👌To test -
Next steps...
It's a little unexpected that the navigation happens after you close the modal, I think I'd expect it on click of the result card when the modal is opened. This may not be an easy change, but I'll timebox a look into this one.
This really highlights to me how valuable it would be to locate your node in the X/Y space of the flow editor. I'll add a card to the backlog for this, and might try to pick it up before a Friday show + tell.