feat(search): Strip HTML tags from search results #3776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/strip-html-tags
branch
from
b6df607 to
fced5ee
Compare
DafyddLlyr
force-pushed
the
dp/search-all-ui
branch
from
5643b2f to
b3034a5
Compare
DafyddLlyr
force-pushed
the
dp/strip-html-tags
branch
from
8841422 to
99de2f4
Compare
DafyddLlyr
force-pushed
the
dp/search-all-ui
branch
from
b3034a5 to
d126766
Compare
DafyddLlyr
force-pushed
the
dp/strip-html-tags
branch
from
99de2f4 to
5223cac
Compare
DafyddLlyr
commented
Oct 9, 2024
| @@ -27,6 +33,7 @@ export const useSearch = <T extends object>({ | |||
| useExtendedSearch: true, | |||
| includeMatches: true, | |||
| minMatchCharLength: 3, | |||
| ignoreLocation: true, | |||
There was a problem hiding this comment.
By default, just the first 60 characters are searched which was giving me some unexpected false negative results.
The testing I've done doesn't make this feel much slower performance-wise - will flag this when this PR is tested.
|
Replaced by #3783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do -