Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Editor graph node link styling #3782

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 8, 2024

What does this PR do?

Fixes a number of styling regressions in the graph introduced by the wrapping div used for tags.

Addresses the following:

  • Blank question sticky notes not appearing correctly
  • Clones not showing correct dashed background
  • Focus and visited states not showing correctly for certain nodes

Preview of fixed graph:
https://3782.planx.pizza/testing/graph-styling-fixed

Copy link

github-actions bot commented Oct 8, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review October 8, 2024 21:32
@ianjon3s ianjon3s requested a review from a team October 8, 2024 21:33
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for getting to bottom of this one !

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one 🙌

@DafyddLlyr
Copy link
Contributor

Merged as it's a noticeable visual regression and we may be doing demos for public show & tell today 👍

@DafyddLlyr DafyddLlyr merged commit 651e15b into main Oct 9, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the ian/fix-graph-node-link-styling branch October 9, 2024 06:41
jessicamcinchak added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants