refactor: change List Map comp to use Trash icon #3809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have altered the props passed to the map component so the reset icon is now a Trash Icon on the List Map input.
<my-map id={id} // TODO // ariaLabelOlFixedOverlay={`An interactive map for plotting and describing ${schema.type.toLocaleLowerCase()}`} height={400} basemap={mapOptions?.basemap} drawMode drawGeojsonData={ features && JSON.stringify({ type: "FeatureCollection", features: features, }) } drawMany={mapOptions?.drawMany} drawColor={mapOptions?.drawColor} drawType={mapOptions?.drawType} drawPointer="crosshair" zoom={20} maxZoom={23} latitude={Number(passport?.data?._address?.latitude)} longitude={Number(passport?.data?._address?.longitude)} ++ resetControlImage="trash" osProxyEndpoint={`${ import.meta.env.VITE_APP_API_URL }/proxy/ordnance-survey`} osCopyright={ mapOptions?.basemap === "OSVectorTile" ? `Basemap subject to Crown copyright and database rights ${new Date().getFullYear()} OS (0)100024857` : `` } clipGeojsonData={ teamSettings?.boundaryBBox && JSON.stringify(teamSettings?.boundaryBBox) } mapboxAccessToken={import.meta.env.VITE_APP_MAPBOX_ACCESS_TOKEN} collapseAttributions />
Following user research feedback outlined in the Trello Ticket: https://trello.com/c/tUPbevRQ/3095-list-switch-map-reset-icon-from-arrow-to-trash-bin-via-existing-web-component-prop