Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change List Map comp to use Trash icon #3809

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Oct 15, 2024

I have altered the props passed to the map component so the reset icon is now a Trash Icon on the List Map input.

<my-map
              id={id}
              // TODO
              // ariaLabelOlFixedOverlay={`An interactive map for plotting and describing ${schema.type.toLocaleLowerCase()}`}
              height={400}
              basemap={mapOptions?.basemap}
              drawMode
              drawGeojsonData={
                features &&
                JSON.stringify({
                  type: "FeatureCollection",
                  features: features,
                })
              }
              drawMany={mapOptions?.drawMany}
              drawColor={mapOptions?.drawColor}
              drawType={mapOptions?.drawType}
              drawPointer="crosshair"
              zoom={20}
              maxZoom={23}
              latitude={Number(passport?.data?._address?.latitude)}
              longitude={Number(passport?.data?._address?.longitude)}
++            resetControlImage="trash"
              osProxyEndpoint={`${
                import.meta.env.VITE_APP_API_URL
              }/proxy/ordnance-survey`}
              osCopyright={
                mapOptions?.basemap === "OSVectorTile"
                  ? `Basemap subject to Crown copyright and database rights ${new Date().getFullYear()} OS (0)100024857`
                  : ``
              }
              clipGeojsonData={
                teamSettings?.boundaryBBox &&
                JSON.stringify(teamSettings?.boundaryBBox)
              }
              mapboxAccessToken={import.meta.env.VITE_APP_MAPBOX_ACCESS_TOKEN}
              collapseAttributions
            />

Following user research feedback outlined in the Trello Ticket: https://trello.com/c/tUPbevRQ/3095-list-switch-map-reset-icon-from-arrow-to-trash-bin-via-existing-web-component-prop

@RODO94 RODO94 requested a review from a team October 15, 2024 15:00
Copy link

github-actions bot commented Oct 15, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member

Great, short & sweet update!

Very nit picky thing: I'm personally finding big diffs in the PR description a bit distracting & not actually more helpful than just switching to "Files changed" tab?

@RODO94 RODO94 merged commit e679bf9 into main Oct 16, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/map-trash-icon branch October 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants