Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simply editor visual settings button group #3810

Closed
wants to merge 8 commits into from
Closed

refactor: Simply editor visual settings button group #3810

wants to merge 8 commits into from

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 16, 2024 •
edited
Loading

What does this PR do?

Builds on the work done by @jessicamcinchak in #3789

  • Move buttons to fixed button group to prevent having to set a fixed bottom/left distance value and replicated styling for each button
  • Allows further buttons to be added without needing specific styling
  • Unifies heights for each button

Before (left) vs after (right):
image

@ianjon3s ianjon3s force-pushed the ian/toggle-images--button-group branch from 1bd023e to 8051058 Compare October 16, 2024 10:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Pizza

Deployed 90bf429 to https://3810.planx.pizza.

Useful links:

@ianjon3s ianjon3s marked this pull request as ready for review October 16, 2024 10:57
@ianjon3s ianjon3s requested review from jessicamcinchak and a team October 16, 2024 10:57
Base automatically changed from jess/toggle-images to main October 16, 2024 11:39
jessicamcinchak
jessicamcinchak reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I missed that this was pointing to my branch before merging - I just merged to main if you don't mind rebasing this one! Then very happy for this to go too, thanks for tidying up styles 🙂

@ianjon3s
Copy link
Contributor Author

Thanks @jessicamcinchak! Sure will rebase from main.

@ianjon3s
Copy link
Contributor Author

Closing in favour of a new PR as I'm getting tangled up with the rebase.

@ianjon3s ianjon3s closed this Oct 16, 2024
@ianjon3s ianjon3s deleted the ian/toggle-images--button-group branch October 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @jessicamcinchak