Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify editor toggle button group #3812

Merged
merged 1 commit into from
Oct 16, 2024
Merged

refactor: Simplify editor toggle button group #3812

merged 1 commit into from
Oct 16, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 16, 2024 •
edited
Loading

What does this PR do?

  • Updates editor toggle button group to have a fixed position and contain inner buttons to prevent having to set a fixed bottom/left distance value and replicated styling for each button
  • Allows further buttons to be added without needing specific styling
  • Unifies heights for each button

Before (left) vs after (right):
image

jessicamcinchak
jessicamcinchak approved these changes Oct 16, 2024
View reviewed changes
editor.planx.uk/src/pages/FlowEditor/index.tsx
background: theme.palette.border.main,
gap: "1px",
overflow: "hidden",
}));
Copy link
Member

@jessicamcinchak jessicamcinchak Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner solution, thank you !!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jessicamcinchak

@ianjon3s ianjon3s marked this pull request as ready for review October 16, 2024 12:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s merged commit 88c237b into main Oct 16, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/editor-toggle-button-tidy branch October 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @jessicamcinchak