feat: Description text for map schema date input #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Good catch!
We could take this a step further by either making the description field required, or setting a default value.
If we wanted to use a default value we could set this in DateFieldInput.tsx.
To make it required (in List/Schema contexts) we'd need to update the DateField type in /Schema/model.ts, something like -
export type DateField = {
type: "date";
data: DateInput & { fn: string, description: string };
};
|
PR was closed in error by accidentally deleting branch. |
ianjon3s
force-pushed
the
ian/map-schema-date-description
branch
from
e56387d to
afc1c2e
Compare
|
Merging this one as-is - will make a new Trello ticket to further discuss "required" placeholders for Date Inputs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For example, 16 04 2027, in line with GOV.UK example.Identified in user-research, 2/5 householder participants tried to enter months using text (i.e. "Nov").
A first instinct was to add a script to insert an example date [for example] 6 months in the future, so that the suggested date would be relevant(ish) and never "expire". Seems like something that can be solved by setting a date well into the future to save unnecessary functionality. Interested to hear other opinions on this.
Preview:
