Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clone display inheritance #3822

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Clone display inheritance #3822

merged 1 commit into from
Oct 17, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 17, 2024

What does this PR do?

Further graph styling fixes.

  • Ensures that filter component node does not expand full width of filter tree
  • Corrects style inheritance on clones so that clone styling wraps full node, and is not inherited by any child nodes / options

Preview:
image

Copy link

github-actions bot commented Oct 17, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review October 17, 2024 10:47
@ianjon3s ianjon3s requested a review from a team October 17, 2024 10:47
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍

We're unintentionally introducing a lot of bugs here as I think as a team we haven't used large stylesheets in a while and are still thinking in components!

I still think that migrating this is best done post-canvas (dependant on timescales!), but we might need to be a bit more diligent in watching out for this type of regression anytime we're making changes to the current graph visualisation.

@ianjon3s ianjon3s merged commit 8e2bd8a into main Oct 17, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/option-clone-styling branch October 17, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants