feat: add Boundary to Map and Label comp #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Oct 17, 2024
DafyddLlyr
reviewed
Oct 17, 2024
| @@ -227,6 +227,8 @@ const Root = () => { | |||
| previouslySubmittedData, | |||
| } = mapAndLabelProps; | |||
|
|
|||
| const [passport] = useStore((state) => [state.computePassport()]); | |||
There was a problem hiding this comment.
fyi: If we're just grabbing a single value, we can use the following notation -
Suggested change
| const [passport] = useStore((state) => [state.computePassport()]); | |
| const passportData = useStore((state) => state.computePassport().data); |
DafyddLlyr
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from user feedback contained in the Trello Ticket: https://trello.com/c/liDbYC96/3094-both-options-show-static-boundary-or-address-point-for-reference-using-geojsondata-prop?filter=member:rorydoak2
We have added the boundary to map components so users can clearly see their property boundary when adding trees.
Main changes are using the
geoJsonDataprop to populate a readonly boundary using passport dataScreen.Recording.2024-10-17.at.11.45.59.mov