refactor: reorganise feedback component folder #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #3838 to merge before I sort the Vultr job here, as I think it is trying to use the same pizza... |
DafyddLlyr
approved these changes
Oct 28, 2024
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was finding all the random storybook files quite confusing, so essentially all I've done is move each component into its own folder:
Also took the opportunity to shorten the length of
index.tsby extracting the types and styled components out to separate files.Wasn't sure of the distinction between index and FeedbackPhaseBanner from the storybook point of view so have left those in the original folder for now.