Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Outstanding test.todo() in Search component #3839

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 23, 2024

Quick update here, realised whilst working on #3783 that there was a test.todo() here that I'd missed.

Please note that the underlying functionality in getURLForNode() is tested elsewhere - all we really care about here is that it's correctly wired up.

@DafyddLlyr DafyddLlyr changed the title test: Outstanding test.todo() in Search component test: Outstanding test.todo() in Search component Oct 23, 2024
@DafyddLlyr DafyddLlyr requested a review from a team October 23, 2024 10:29
Copy link

github-actions bot commented Oct 23, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit a9bda7d into main Oct 23, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/search-test-todos branch October 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants