feat: add basic in-page feedback component #3841
Conversation
|
Removed vultr server and associated DNS entries |
jamdelion
changed the title
There was a problem hiding this comment.
Nice to see a Storybook first approach! 🙌
One small nit is that the hover shadows should match the border -
When it comes to the next steps of configuring the component, there's docs on this here.
editor.planx.uk/src/@planx/components/Feedback/components/FaceBox.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Feedback/components/FaceBox.tsx
Outdated
Show resolved
Hide resolved
Nice catch, I'm seeing that on my side now as well! Will investigate... 👀 |
| </Typography> | ||
|
|
||
| <Box pt={2} mb={3}> | ||
| <InputLabel label="How would you rate your experience with this service?" /> |
There was a problem hiding this comment.
The hover issue was caused by having more than one child inside the label component, as discussed in this issue: mui/material-ui#14543
I've made the children prop optional in the InputLabel component to get round this.
There was a problem hiding this comment.
Ah nice one 👍
Alternatively, I think we could make children a ReactElement which would force a single element or fragment here. This will likely have cascading type issues but may point at other places where we're hitting a similar hover issue?
The a11y tests are still passing in CI and Storybook without the wrapping label, so this is all good as-is.
This is currently just adding the first pass at the Feedback component in storybook.
Next steps
In future PRs here are the todos:
Links
Trello ticket: https://trello.com/c/jEOLoubW/3034-can-we-introduce-in-house-end-of-service-feedback?filter=member:johumphrey6
Figma design: https://www.figma.com/design/bnUUrsVRG6qPwDkTmVKACI/PlanX-Design?node-id=16904-1689&t=mx6FzCppbhIfPsBM-4