feat: Remove duplicated Destination enums, add Send test coverage
#3843
Conversation
DafyddLlyr
changed the title
SendDestination enums, add Send test coverage
DafyddLlyr
changed the title
SendDestination enums, add Send test coverageDestination enums, add Send test coverage
| const url = `${ | ||
| import.meta.env.VITE_APP_API_URL | ||
| }/create-send-events/${sessionId}`; | ||
| const request: any = useAsync(async () => { |
There was a problem hiding this comment.
This any was the cause of a bug where event ids are not logged to the breadcrumb.
The list below has request.value.bops, request.value.uniform etc, but it should be request.value.data.bops, request.value.data.uniform etc
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
These ids will be UUIDs, just correctly updating mock here.
| breadcrumbs: { | ||
| findProperty: { | ||
| data: { | ||
| "property.localAuthorityDistrict": ["Some local authority district"] |
There was a problem hiding this comment.
nit: more realistic mock here would be ["Buckinghamshire", "Historic district name"] - eg because I think we want to confirm we are correctly filtering modern council name out of property.localAuthorityDistrict array !
There was a problem hiding this comment.
Ah of course - very good catch - best to be as explicit and through as possible here.
Updated in 480d86b
| bopsSendEventId: hasuraEventsResponseMock.bops.event_id, | ||
| uniformSendEventId: hasuraEventsResponseMock.uniform.event_id, | ||
| })); | ||
| }); |
There was a problem hiding this comment.
Test coverage is long overdue, clear & thorough here, thank you!!
Likewise - I've not manually tested each submission here, just the event creation which this should only be touching. I've got a good degree of confidence that current test coverage is good here 👍 |
What does this PR do?
SendIntegrationtype fromplanx-core(please see feat: Add send integration types planx-core#540)DestinationenumDestinationenumSendcomponent - currently this does not work on staging - due to an incorrect type the breadcrumb remains emptyAlso...
Picked up a few associated refactors in the frontend
Sendcomponent, alongside adding some test coverage for theSendcomponent.What's the motivation here?
As part of the GOSS integration I'm aiming to write some docs on "how to set up a send integration". This work is aiming to simplify this process so that it hopefully boils down to just the following -
SendIntegrationarray inplanx-coreplanx-newEditor componentHopefully then TypeScript will do a lot of the heavy lifting for the places where there are references to
SendIntegrationsthat need to be updated.There's still some room for improvement here I think - there's repeated logic in a few places still, but I'll pick up additional changes in another PR if they feel necessary. This is a big enough PR for now!