-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Hasura column presets to populate creator_id
#3864
Conversation
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (2)
|
@RODO94 Could you please also run E2E regression tests against this branch just to check that this method holds up with the mocking we've done there? |
Removed vultr server and associated DNS entries |
@DafyddLlyr Regression tests have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a nitpick sorry, but there's no linting set up for this file afaik - it looks like it's your local IDE config that's changes from "
to '
here.
Could you please change this back so that the only diff you've made for the column presets shows here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks
This follows work on the demo workspace ticket: https://trello.com/c/EfaEQRzK/2441-create-a-demo-workspace
We found that the
creator_id
was not populating when we create a flow in the editor. To fix this, we decided to use Hasura Column Presets to reduce the number of places the change had to be made, and to make it more maintainable in the future.We do sacrifice readability in the code base, but we found it was a better win for maintainability for a data field most people would expect to be populated by the user creating it.
Column Preset Docs