fix: Update publishing details on flow change #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Oct 29, 2024
|
|
||
| const _validateAndDiffRequest = useAsync(async () => { | ||
| const newChanges = await validateAndDiffFlow(flowId); | ||
| setAlteredNodes( | ||
| newChanges?.data.alteredNodes ? newChanges.data.alteredNodes : [], | ||
| ); | ||
| }); | ||
| }, [flowId]); |
There was a problem hiding this comment.
Technically this should update each time there's an operation on the current flow or any nested flow, but I think this would be calling this expensive API call a lot more than we want to.
Having it update once when navigating into a flow feels fine as a fix for now.
|
Removed vultr server and associated DNS entries |
jamdelion
approved these changes
Oct 29, 2024
|
|
||
| const _validateAndDiffRequest = useAsync(async () => { | ||
| const newChanges = await validateAndDiffFlow(flowId); | ||
| setAlteredNodes( | ||
| newChanges?.data.alteredNodes ? newChanges.data.alteredNodes : [], | ||
| ); | ||
| }); | ||
| }, [flowId]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://opensystemslab.slack.com/archives/C01E3AC0C03/p1730197158271359
What's the problem?
What's the solution
flowIdto the dependency arrays of the functions responsible for updating these values