feat: add `application.type' to allow list for Metabase #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert prettier changes add application type migration for analytics and submissions revert tables.yaml changes
RODO94
force-pushed
the
rory/metabase-app-type
branch
from
06cc154 to
2672b55
Compare
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Oct 30, 2024
api.planx.uk/modules/webhooks/service/analyzeSessions/operations.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
I have added
application.typeto theALLOW_LISTin the relevant api and editor repos, and I have added a migration to add aapplication_typeto theanalytics_summaryand thesubmission_services_summaryRan through Southwarks Apply for Planning Permission service and tested the output, and received
["pp.full.householder"]in theanalytics_summaryand the same in thesubmission_services_summaryIf this is all good, I'll work up a how-to doc for future ref