feat: demo workspace e2e #3889
Merged
feat: demo workspace e2e #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
add new scenarios to feature file revert ui-driven test changes update feature with new tests add step structure and helper
add Given logic and alter jwt build for demoUser lint fix refine Given statements add When steps add Then steps lint:fix tidy verification and helper
RODO94
force-pushed
the
rory/demo-e2e
branch
from
80e1e14 to
24242e2
Compare
refine race condition Promise.All improve error catching on createFlow
RODO94
force-pushed
the
rory/demo-e2e
branch
from
1b97644 to
1623a33
Compare
fix MyMutation naming
RODO94
force-pushed
the
rory/demo-e2e
branch
from
3da8ef4 to
ed9bf95
Compare
jamdelion
reviewed
Nov 11, 2024
e2e/tests/api-driven/src/demo-workspace/steps/navigation_steps.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR follows on for demo workspace work here: https://trello.com/c/EfaEQRzK/2441-create-a-demo-workspace
I have written a suite of api-driven e2e tests to ensure
demoUserrestrictions and capabilities are maintained during future code changes.Strategy
To ensure a future dev could understand the tests and the nuances around database permissions, I have explicitly written out what data should be in the database during the tests in the
Givenstatements within theBackgroundof the.featurefile. With this, I am able to populate the db directly with thedatatableinformation.To support the range of scenarios and different situations, I have split out the
.stepsfile out intobackground | navigation | verificationwith each file handling either theGivensteps, theWhensteps, or theThen | Butsteps.This felt better from a readability point of view as putting them all in the same file became unwieldy and collating
WhenorThenconditions seem to abstract the point of some of the tests.The
helper.tsfile contains a lot of GraphQL requests because I had to return specific data or send specific data and found the shared requests didn't give me enough control on things likeid & creator_id. This is similar for the types likeFlowetc.Struggles
I did struggle a bit with the right design patterns here and thinking about what code should sit within which kind of step, what goes in a
Whencompared with aThenbut I hope my use of state helps this.I seem to hit a randomly occurring error as well around the creation of flows, I couldn't pinpoint how it is happening or what is causing it. The addition or removal of a
console.errorseems to trigger the error sometimes, so I thought it may be a race condition around aPromise.all()but I couldn't root it out... if anyone finds something, let me know, for now it is all passing.