Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add basic timers to validateAndDiffFlow() #3906

Closed
wants to merge 1 commit into from
Closed

chore: Add basic timers to validateAndDiffFlow() #3906

wants to merge 1 commit into from

Conversation

DafyddLlyr
Copy link
Contributor

No description provided.

@DafyddLlyr DafyddLlyr marked this pull request as draft November 4, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr
Copy link
Contributor Author

Closing this - I was able to test this locally to test our assumptions. It is dataMerged() which is taking a lot of time here

2024-11-04 12:58:35 flattenedFlow() took 177378.05 ms
2024-11-04 12:58:39 jsondiffpatch.diff() took 463.17 ms

@DafyddLlyr DafyddLlyr closed this Nov 4, 2024
@DafyddLlyr DafyddLlyr deleted the dp/timer-validate-diff branch November 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DafyddLlyr