Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add team_settings introspection tests #3909

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: add team_settings introspection tests #3909

merged 1 commit into from
Nov 5, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Nov 4, 2024 •
edited
Loading

While doing the demoUser work, we found that we were missing introspection tests for team_settings.

I have mocked these off the team_themes introspection tests since the permissions are mirrored

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@RODO94 RODO94 marked this pull request as ready for review November 4, 2024 15:51
@RODO94 RODO94 requested a review from a team November 4, 2024 15:51
DafyddLlyr
DafyddLlyr approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up 👍

@RODO94 RODO94 merged commit 5bb064a into main Nov 5, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/introspection-team-settings branch November 5, 2024 09:15
@RODO94
Copy link
Contributor Author

RODO94 commented Nov 5, 2024

Create a 'demo' workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RODO94 @DafyddLlyr