fix: add missing postgres indexes #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Nov 4, 2024
| CREATE INDEX "reconciliation_requests_session_id_idx" on | ||
| "public"."reconciliation_requests" using hash ("session_id"); | ||
| CREATE INDEX "published_flows_created_at_idx" on | ||
| "public"."published_flows" using btree ("created_at"); |
There was a problem hiding this comment.
A couple notes about this migration:
- Why a mix of
hashversusbtreeindex types?- I'm using
hashindices when it's a column that is exclusively queried via an equality check (eg session id) andbtreeindices when a) it's a column that is queried via equality or range checks or b) multiple columns are combined into the same index - Postgres docs on this are helpful https://www.postgresql.org/docs/current/indexes-types.html
- I'm using
- I'm adding an index to
published_flows.created_atbecause that is how all of our current queries are ordering, but I have not actually checked/compared yet if there's a difference to sort by published flow id (or jogged my memory about why we don't do this already). Even if we swap how we order in the future, an index oncreated_atshould still be useful/hit here when we do date comparisons for reconciliation
There was a problem hiding this comment.
It may also be worth adding a DESC in here as we're always searching in this order (docs).
There was a problem hiding this comment.
Cool good shout - that's now updated 👍 Worth noting order isn't possible to specify in Hasura GUI for adding indexes, but worked no problem when added via "SQL" panel directly
jessicamcinchak
commented
Nov 4, 2024
| @@ -157,7 +157,7 @@ | |||
| definition: | |||
| enable_manual: false | |||
| insert: | |||
| columns: "*" | |||
| columns: '*' | |||
There was a problem hiding this comment.
This file is only formatting changes 🌀
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Nov 4, 2024
| CREATE INDEX "reconciliation_requests_session_id_idx" on | ||
| "public"."reconciliation_requests" using hash ("session_id"); | ||
| CREATE INDEX "published_flows_created_at_idx" on | ||
| "public"."published_flows" using btree ("created_at"); |
There was a problem hiding this comment.
It may also be worth adding a DESC in here as we're always searching in this order (docs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from publishing debugging today: https://opensystemslab.slack.com/archives/C01E3AC0C03/p1730715895034839
Approached this from two directions:
whereparams)select * from pg_stat_user_indexes where schemaname = 'public' order by idx_scan asc;for this oneWish that
published_flows&flowswould have come up higher on the "need to improve" checks, but the truth is they didn't !