Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter questions without responses out of generated docs #3918

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 6, 2024

See theopensystemslab/planx-core#556 for context

Testing notes:
This flow has a sticky note question, put-to-user question, and auto-answered question https://3918.planx.pizza/testing/docs-test/published?analytics=false

Here's how each should be handled by the following components / documents:

  • Result: put-to-user and auto-answered questions may be included under "Reasons" depending on flags, only put-to-user questions should have a "change" link
  • Review: only put-to-user questions are included, all have "change" link
  • Submission docs:
    • overview.html: put-to-user and auto-answered questions are included, with "auto-answered" annotation
    • application.csv: put-to-user and auto-answered questions are included, with "auto" metadata
    • application.json (responses): put-to-user and auto-answered questions are included, with "auto" metadata

None of the above should ever include the sticky note question title/text with an empty answer!

Copy link

github-actions bot commented Nov 6, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review November 6, 2024 20:08
@jessicamcinchak jessicamcinchak requested a review from a team November 6, 2024 20:08
@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak merged commit bd72ea3 into main Nov 7, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/bump-planx-core-72e7f7f branch November 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants