Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup Southwark with S3 Power Automate integration tokens plus howto doc #3931

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 11, 2024

Southwark is ready to replicate Barnet's work on the S3/Power Automate integrations - this sets up 4x API tokens for them to do so. See how-to doc for further explanation.

All encrypted values have been added to teams_integration table via prod Hasura console & synce to staging already. AWS S3 pizza-secrets has also been updated with staging file api key values.

Copy link

github-actions bot commented Nov 11, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak marked this pull request as ready for review November 12, 2024 09:34
@jessicamcinchak jessicamcinchak requested a review from a team November 12, 2024 09:38
Comment on lines 21 to +23
FILE_API_KEY_NEXUS=👻
FILE_API_KEY_BARNET=👻
FILE_API_KEY_SOUTHWARK=👻
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably about time we moved these to team_integrations as well I think 👍

Comment on lines +95 to +96
req.headers["api-key"] as string,
process.env.FILE_API_KEY_SOUTHWARK!,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd also constrain this to Southwark requests, but the current S3 setup doesn't support this.

Copy link
Contributor

@jamdelion jamdelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see doc improvements 🙌

doc/how-to/how-to-setup-aws-s3-submissions.md Outdated Show resolved Hide resolved
doc/how-to/how-to-setup-aws-s3-submissions.md Outdated Show resolved Hide resolved
@jessicamcinchak jessicamcinchak merged commit 14f5f12 into main Nov 12, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/southwark-s3-power-automate-setup branch November 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants