fix: safer destructuring in autoAnswerableOptions to prevent error on initial editor load
#3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when we're loading flows, we're sometimes attempting to run
autoAnswerableOptionsbefore the whole flow has loaded (eg on_rootnode rather than true current card??) leading to errors like the one screenshot below & reported by Ian Grace in #help-issues here: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1731336388546549This tries destructuring the single
nodefirst before immediately assuming it has{ type, data, edges }too, similar with passport to account for cases where it's empty (eg nodatayet)