feat: demo team integrations to fail gracefully #3938
Conversation
|
Removed vultr server and associated DNS entries |
RODO94
force-pushed
the
rory/demo-integrations-fail
branch
from
3a441de to
38286f3
Compare
RODO94
force-pushed
the
rory/demo-integrations-fail
branch
from
b613f15 to
13d917e
Compare
There was a problem hiding this comment.
A few small language questions/suggestions - but Pay & Send are working as expected ✔️
Re: Planning Constraints, while we can "turn this on" in the demo team, it WILL return "false negatives".
We allow applicants to enter any postcode in all of England or Wales per the OS Places API in FindProperty, but Planning Data only hosts constraints for ODP-onboarded councils. Planning Data's API returns the same response for constraints that have been checked but don't intersect and for constraints that do not have underlying source data to check in the first place - therefore why we have the manual toggle in the first place.
I personally think it's a lot more confusing/inaccurate to show folks "working" constraints that are going to say something doesn't apply when they may personally know that it does (but they haven't submitted their datasets to Planning Data yet) and have to explain the concept of "false negatives" - therefore would prefer an error message in that case as well please !!
copy refinement on pay comp copy refinement on pay comp copy refinement on pay comp
scroll to view warning message revert scroll view and simplify demo user screens refine boolean code and remove redundant space copy refinement on send component
RODO94
force-pushed
the
rory/demo-integrations-fail
branch
from
a68bfc2 to
278f44b
Compare
simplify pay error and add tests remove unused variables remove it.only alter state val on unit test
RODO94
force-pushed
the
rory/demo-integrations-fail
branch
from
b6647b1 to
5716f09
Compare
editor.planx.uk/src/@planx/components/PlanningConstraints/Public.tsx
Outdated
Show resolved
Hide resolved
Adding some failure screens with Send Components and Planning Constraints to gracefully catch errors and inform the
demoUsersof certain restrictions in the Public interface, rather than the Editor one. Found this better as it would still show our range of components (things like Planning Constraints) while removing a potentially confusing experience for users.For demoUsers, they may still see these components normally when in other teams, like ODP, but they just can't see them when they are within the Demo team.
This is because for the Public interface of the components, we don't have access to a User object which would help us manage it specifically for a
demoUserrole which sits within theteamssection of auserobject, as it is applied to theteam_memberstable.Feedback on this component has been given here: https://opensystemslab.slack.com/archives/C04DZ1NBUMR/p1731576342896299