feat: Display feedback score in feedback log #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
jamdelion
changed the title
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 13, 2024
| } | ||
|
|
||
| const feedbackScore = | ||
| item.feedbackScore && EmojiRating[item.feedbackScore + 1]; // enums are 0-indexed |
| @@ -52,6 +52,9 @@ export const FeedbackLog: React.FC<FeedbackLogProps> = ({ feedback }) => { | |||
| <TableCell sx={{ width: 100 }}> | |||
| <strong>Date</strong> | |||
| </TableCell> | |||
| <TableCell sx={{ width: 140 }}> | |||
| <strong>Feedback score</strong> | |||
There was a problem hiding this comment.
nit: since we're already in the "Feedback log", can this heading simply be "Score" (these tables don't have tons of real estate to begin with!)
There was a problem hiding this comment.
Good idea, I've used the word 'rating' instead given that the word (e.g. fair, good, average) is being displayed rather than the numeric value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
feedback_summarytable to copy across thefeedbackScorefrom thefeedbacktable.