Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add description and templated_from to flows table #3945

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Nov 13, 2024

To help lay the groundwork for the Templates feature, I have added two new columns to the flows table:

description and templated_from

I have updated the necessary permissions so admins, editors, and demoUsers can all create, update, and see description.

No permissions have been enabled for templated_from.

I'll follow this PR with another one to create an input for description in service settings of the flowEditor

Copy link

github-actions bot commented Nov 13, 2024

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.flows permissions:

    insert select update delete
    api / / /
    demoUser / / /
    platformAdmin / / /
    teamEditor / / /
    12 added column permissions
    insert select update
    api ➕ description ➕ description ➕ description
    demoUser
    platformAdmin
    teamEditor

@RODO94 RODO94 marked this pull request as ready for review November 13, 2024 11:53
@RODO94
Copy link
Contributor Author

RODO94 commented Nov 13, 2024

Templates groundwork

@RODO94 RODO94 requested a review from a team November 13, 2024 11:54
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permissions all look good here! One small comment re: data type (was my mistake on Trello). Also, not crucial, but please consider squashing migrations when single PR and commands on same table !

Copy link

github-actions bot commented Nov 13, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updates!

@RODO94 RODO94 merged commit 29a88f6 into main Nov 13, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/templates-hasura branch November 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants