fix: customise and move location of Notice component More Information button #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustlindemer
commented
Nov 13, 2024
| info={props.info} | ||
| policyRef={props.policyRef} | ||
| howMeasured={props.howMeasured} | ||
| /> |
There was a problem hiding this comment.
The Notice component uses CardHeader for its More Information button. Because we don't want a title above the content block (the notice), it does so without passing a title prop. Because CardHeader uses the title prop to customise the aria-label of the More information button, the Notice component returns undefined in this aria-label.
There was a problem hiding this comment.
Great spot & accessibility fix 🌟
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 13, 2024
| info={props.info} | ||
| policyRef={props.policyRef} | ||
| howMeasured={props.howMeasured} | ||
| /> |
There was a problem hiding this comment.
Great spot & accessibility fix 🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the Notice component has a defined aria-label for its More information button and displays this button below its content block (if defined).
It replaces the use of CardHeader in the Notice component with a custom More information layout using a static aria-label (copying the approach used for the Content component).