Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always center flows on load #3953

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix: Always center flows on load #3953

merged 2 commits into from
Nov 15, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 14, 2024 •
edited
Loading

What does this PR do?

Following #3854 there was some valuable feedback on how this should behave which I'll pick up in follow up PRs.

@DafyddLlyr DafyddLlyr marked this pull request as draft November 14, 2024 13:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/always-center-flows branch from eda883e to 021e047 Compare November 14, 2024 15:46
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 14, 2024 16:22
@DafyddLlyr DafyddLlyr requested a review from a team November 15, 2024 09:19
RODO94
RODO94 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the functionality works for me when I try to move between portals, it centres back to the top... if that was the intent

@DafyddLlyr
Copy link
Contributor Author

Flows should be centered within the window on initial load

@DafyddLlyr DafyddLlyr merged commit b92d401 into main Nov 15, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/always-center-flows branch November 15, 2024 09:38
@DafyddLlyr DafyddLlyr mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RODO94 RODO94 RODO94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @RODO94