Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only trigger email_user_submission_confirmation event once per session #3967

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 15, 2024

What's the problem?

  • When an application is submitted to multiple locations, the email_user_submission_confirmation event trigger is called multiple times, resulting in multiple emails being sent to applicants from PlanX.
  • This is recreatable locally, and can be observed as a pattern via GovNotify or the Hasura event log - we can see grouped events and emails for the same PlanX session

What's the solution?

  • Adds a check within the query, so that the trigger is only called once

Copy link

github-actions bot commented Nov 15, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team November 15, 2024 16:15
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 15, 2024 16:15
@DafyddLlyr
Copy link
Contributor Author

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@DafyddLlyr DafyddLlyr merged commit 08f9c5b into main Nov 18, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/single-submission-email branch November 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants