feat: add user_clicked_save to analytics_summary view
#3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
RODO94
force-pushed
the
rory/metab-user-clicked
branch
from
7634e30 to
9e22abe
Compare
DafyddLlyr
requested changes
Nov 19, 2024
...ions/1732016907414_alter_table_public_analytics_logs_add_column_has_user_clicked_save/up.sql
Outdated
Show resolved
Hide resolved
...ions/1732016907414_alter_table_public_analytics_logs_add_column_has_user_clicked_save/up.sql
Outdated
Show resolved
Hide resolved
RODO94
force-pushed
the
rory/metab-user-clicked
branch
from
43c1966 to
a981794
Compare
add new view migration squash migrations alter order of down file remove async fix down sql
RODO94
force-pushed
the
rory/metab-user-clicked
branch
from
af91e7a to
c45dd19
Compare
DafyddLlyr
reviewed
Nov 20, 2024
DafyddLlyr
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the metabase ticket: https://trello.com/c/2j5CC6IG/3124-expose-userclickedsave-in-analyticssummary
Added extra data to the analytics_summary view to support the pilot work
Updated permissions to mirror
has_clicked_helpI am only using the
SaveAndResumeButtoncomponent to trigger thistrackEvent()Note
It will not populate
analytics_logsif it is on the first node, due tolastVisibleNodeAnalyticsLogIdbeingundefinedso it will failif (shouldSkipTracking()) return;intrackEvent(). In normal cases, I'd imagine we'd have some form of intro node or something similar and this is the current behaviour for all cases so I wasn't going to begin pulling on threads here.