chore: retire custom ESRI GIS integrations #3977
Conversation
|
Removed vultr server and associated DNS entries |
|
|
||
| // Fetch planning constraints data for a given local authority | ||
| const root = `${import.meta.env.VITE_APP_API_URL}/gis/${teamSlug}?`; | ||
| const teamGisEndpoint: string = | ||
| root + | ||
| new URLSearchParams( | ||
| hasPlanningData ? digitalLandParams : customGisParams, | ||
| hasPlanningData ? planningDataParams : undefined, |
There was a problem hiding this comment.
Are we relying on this failing because geom will be undefined when the request is made?
If !hasPlanningData should be guard against making the request full stop?
There was a problem hiding this comment.
Already need to revisit these request conditions in #3968 (eg only make "roads" request if the editor has specified they want to check roads and they have a USRN) - so going to take these comments forward into that PR is ok!
| @@ -22,8 +20,7 @@ const localAuthorities = { digitalLand, braintree, scotland }; | |||
| * description: Well-Known Text (WKT) formatted polygon or point | |||
| */ | |||
| export async function locationSearch(req, res, next) { | |||
| // 'geom' param signals this localAuthority has data available via DigitalLand, "ready" teams are configured in PlanningConstraints component in editor | |||
| // swagger doc intentionally doesn't cover legacy custom GIS hookups for Braintree and Scotland demo | |||
| // 'geom' param signals this localAuthority has data available via Planning Data | |||
There was a problem hiding this comment.
Aha this answers my previous question - maybe a check against hasPlanningData in both places is a bit more robust / expected.
There was a problem hiding this comment.
Thanks for the bonus .js → .ts here as well ✨
|
A small follow up task here is to remove legacy custom GIS endpoints from UptimeRobot also. |
In the past before Planning Data, we integrated directly with local ESRI GIS servers - notably for Braintree council and a demo for the Scottish government. Waiting for OK here: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1731954174803899
We no longer anticipate supporting this integration approach, so I'm fully removing these files as they add a fair amount of complexity to how we handle planning constraints. If we ever need to spin up demos again, the ESRI helpers especially should be find-able & easy to re-implement/revert 🙂