Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup Metabase env variables #3992

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat: setup Metabase env variables #3992

merged 5 commits into from
Nov 21, 2024

Conversation

zz-hh-aa
Copy link
Collaborator

@zz-hh-aa zz-hh-aa commented Nov 20, 2024 •
edited
Loading

Following the 'How to add a secret' guide, this PR

  • Adds Metabase staging & production keys to Pulumi files in infrastructure/application
  • Adds vars to api.planx.uk/.env.test.example

Came out of feedback on #3970

@zz-hh-aa zz-hh-aa requested a review from DafyddLlyr November 20, 2024 16:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@zz-hh-aa zz-hh-aa mentioned this pull request Nov 20, 2024
Merged
DafyddLlyr
DafyddLlyr requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional steps required! I've also improved the documentation a little here which hopefully helps to explain some of this setup 🙂

https://github.com/theopensystemslab/planx-new/pull/3994/files?short_path=0285396#diff-02853966ac252e3f0d2457668dde4f04312e4e501fa8a05d8d4ac18256364f17

api.planx.uk/.env.test.example Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@DafyddLlyr DafyddLlyr mentioned this pull request Nov 20, 2024
Merged
@zz-hh-aa zz-hh-aa merged commit c3cac3c into main Nov 21, 2024
10 of 11 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/setup-metabase-vars branch November 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zz-hh-aa @DafyddLlyr