Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add retry to flaky react unit test #4002

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 22, 2024

This test has been failing on a number of CI runs, and then usually passes on a retry.

image

I'm not able to recreate this locally, so I'm adding in a retry to see if this mitigates the issue.

Once this is up and running, I'll retry the react tests a bunch of time on CI to check that a single retry actually seems to resolve this.

Update: Ran this multiple times, no issues so far 🤞

image

@DafyddLlyr DafyddLlyr requested a review from a team November 22, 2024 09:16
Copy link

github-actions bot commented Nov 22, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, the change looks good to me. Hopefully just 1 retry is enough, but yeah it's a tough one to recreate the flake.

@DafyddLlyr DafyddLlyr merged commit d325ed7 into main Nov 22, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/retry-flaky-test branch November 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants