Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: External Portal node graph styling #4004

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 22, 2024

Please see https://opensystemslab.slack.com/archives/C01E3AC0C03/p1732286143726329 (OSL Slack)

Fixed small visual regressions introduced in #3975, and adds back missing refs.

image

@DafyddLlyr DafyddLlyr requested a review from a team November 22, 2024 15:08
Copy link

github-actions bot commented Nov 22, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask to include the Internal Portal here with this change? Realised I missed it when adding tags

Should be:

  return (
    <>
      <Hanger hidden={isDragging} before={props.id} parent={parent} />
      <li ref={ref}>
        <Box className={classNames("card", "portal", { isDragging })}>
          <Link
            href={href}
            prefetch={false}
            ref={drag}
            onContextMenu={handleContext}
          >
            {Icon && <Icon />}
            <span>{props.data.text}</span>
          </Link>
          <Link href={editHref} prefetch={false} className="portalMenu">
            <MoreVert titleAccess="Edit Portal" />
          </Link>
        </Box>
        {props.tags?.map((tag: NodeTag) => <Tag tag={tag} key={tag} />)}
      </li>
    </>
  );

@DafyddLlyr
Copy link
Contributor Author

@RODO94 Yep! Added in af8082e

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DafyddLlyr DafyddLlyr merged commit 7094c52 into main Nov 25, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/ext-portal-styling branch November 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants